[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612334#comment-16612334 ]
Hadoop QA commented on HBASE-21174: ----------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 43s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 34s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} hbase-rest: The patch generated 0 new + 16 unchanged - 10 fixed = 16 total (was 26) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 38s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 1m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 29s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 9s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:61288f8 | | JIRA Issue | HBASE-21174 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12939419/HBASE-21174.branch-1.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9afb645f6987 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-1 / 158607b | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_191 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_181 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_191 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14400/testReport/ | | Max. process+thread count | 2157 (vs. ulimit of 10000) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14400/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > [REST] Failed to parse empty qualifier in TableResource#getScanResource > ----------------------------------------------------------------------- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST > Affects Versions: 3.0.0, 2.2.0 > Reporter: Guangxu Cheng > Assignee: Guangxu Cheng > Priority: Major > Attachments: HBASE-21174.branch-1.001.patch, > HBASE-21174.master.001.patch, HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1&column=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)