[ 
https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614279#comment-16614279
 ] 

Ted Yu commented on HBASE-21160:
--------------------------------

As I said above, when there is no assertion at the end of try block, you don't 
need to make change.

Please also keep the try-with-resources structure which releases resource.

> Assertion in 
> TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels
>  is ignored
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-21160
>                 URL: https://issues.apache.org/jira/browse/HBASE-21160
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: liubangchen
>            Priority: Trivial
>
> From 
> https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt
>  (HBASE-21138 QA run):
> {code}
> [WARNING] 
> /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25]
>  [AssertionFailureIgnored] This assertion throws an AssertionError if it 
> fails, which will be caught by an enclosing try block.
> {code}
> Here is related code:
> {code}
>       PrivilegedExceptionAction<Void> scanAction = new 
> PrivilegedExceptionAction<Void>() {
>         @Override
>         public Void run() throws Exception {
>           try (Connection connection = 
> ConnectionFactory.createConnection(conf);
> ...
>             assertEquals(1, next.length);
>           } catch (Throwable t) {
>             throw new IOException(t);
>           }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to