[
https://issues.apache.org/jira/browse/HBASE-21102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619886#comment-16619886
]
Ted Yu commented on HBASE-21102:
--------------------------------
>From
>https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1267/testReport/junit/org.apache.hadoop.hbase.master.balancer/TestRSGroupBasedLoadBalancer/health_checks___yetus_jdk8_hadoop3_checks___testRetainAssignment/
> :
{code}
java.lang.NullPointerException
at
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer.testRetainAssignment(TestRSGroupBasedLoadBalancer.java:166)
{code}
It was due to this code:
{code}
if (this.services != null && this.services.getAssignmentManager() !=
null) { // for tests
if (!hasRegionReplica &&
this.services.getAssignmentManager().getRegionStates()
.isReplicaAvailableForRegion(region)) {
{code}
this.services.getAssignmentManager().getRegionStates() may return null.
Ram:
Can you take a look at 21102.addendum2.txt ?
The above test passes with the additional check.
> ServerCrashProcedure should select target server where no other replicas
> exist for the current region
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-21102
> URL: https://issues.apache.org/jira/browse/HBASE-21102
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Affects Versions: 3.0.0, 2.2.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Major
> Attachments: 21102.addendum2.txt, HBASE-21102_1.patch,
> HBASE-21102_2.patch, HBASE-21102_3.patch, HBASE-21102_4.patch,
> HBASE-21102_addendum.patch, HBASE-21102_addendum.patch,
> HBASE-21102_addendum.patch, HBASE-21102_branch-2.1.patch,
> HBASE-21102_branch-2.1.patch, HBASE-21102_initial.patch
>
>
> Currently when a server with region replica crashes, when the target server
> is created for the replica region assignment there is no guarentee that a
> server is selected where there is no other replica for the current region
> getting assigned. It so happens that currently we do an assignment randomly
> and later the LB comes and identifies these cases and again does MOVE for
> such regions. It will be better if we can identify target servers at least
> minimally ensuring that replicas are not colocated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
