saintstack commented on a change in pull request #3: HBASE-21002 make an
assembly for hbase-connectors
URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218131154
##########
File path: pom.xml
##########
@@ -167,21 +170,34 @@
<artifactId>hbase-client</artifactId>
<version>${hbase.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.hbase.connectors</groupId>
- <artifactId>hbase-kafka-model</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.hbase.connectors</groupId>
- <artifactId>hbase-kafka-proxy</artifactId>
- <version>${project.version}</version>
- </dependency>
+
+
+ <dependency>
+ <groupId>org.apache.hbase.connectors</groupId>
+ <artifactId>hbase-kafka-proxy</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.hbase.connectors</groupId>
+ <artifactId>hbase-kafka-model</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+
</dependencies>
</dependencyManagement>
<build>
<pluginManagement>
<plugins>
+ <plugin>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <configuration>
+ <!--Defer to the hbase-connector-assembly sub-module. It
+ does all assembly-->
+ <skipAssembly>true</skipAssembly>
+ </configuration>
+ </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
Review comment:
This is great. Will merge in a while. Leaving it open another while in case
other comments.
I suppose we could change the model for how we do our scripts perhaps
bringing in the new hadoop3 mode but that we can do in a follow-on. This is a
very nice start.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
