[ 
https://issues.apache.org/jira/browse/HBASE-21207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623905#comment-16623905
 ] 

Andrew Purtell commented on HBASE-21207:
----------------------------------------

Thanks for the patches [~archana.katiyar]. There are some minor issues with 
them. 

Please remove these changes:
{noformat}
 .../resources/hbase-webapps/static/css/asc.gif     | Bin 0 -> 54 bytes
 .../main/resources/hbase-webapps/static/css/bg.gif | Bin 0 -> 64 bytes
 .../resources/hbase-webapps/static/css/desc.gif    | Bin 0 -> 54 bytes
{noformat}

Pease fix the reported whitespace issues. 

We also need a small POM change to exclude the new jquery.tablesorter.min.js 
file. See how we do it for the other minimized jquery file:

./pom.xml:844:              <exclude>**/jquery.min.js</exclude>

You'll add another line below it to exclude the file your patch is adding. 

Otherwise the changes look good to me. 

> Add client side sorting functionality in master web UI for table and region 
> server details.
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-21207
>                 URL: https://issues.apache.org/jira/browse/HBASE-21207
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, monitoring, UI, Usability
>            Reporter: Archana Katiyar
>            Assignee: Archana Katiyar
>            Priority: Minor
>         Attachments: 14926e82-b929-11e8-8bdd-4ce4621f1118.png, 
> 2724afd8-b929-11e8-8171-8b5b2ba3084e.png, HBASE-21207-branch-1.patch, 
> HBASE-21207.patch, edc5c812-b928-11e8-87e2-ce6396629bbc.png
>
>
> In Master UI, we can see region server details like requests per seconds and 
> number of regions etc. Similarly, for tables also we can see online regions , 
> offline regions.
> It will help ops people in determining hot spotting if we can provide sort 
> functionality in the UI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to