[
https://issues.apache.org/jira/browse/HBASE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221952#comment-13221952
]
Hadoop QA commented on HBASE-5510:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517004/HBase-5010_3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -129 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 154 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1092//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1092//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1092//console
This message is automatically generated.
> Change in LB.randomAssignment(List<ServerName> servers) API
> -----------------------------------------------------------
>
> Key: HBASE-5510
> URL: https://issues.apache.org/jira/browse/HBASE-5510
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Anoop Sam John
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
> Attachments: HBase-5010_3.patch, HBase-5510.patch, HBase-5510_2.patch
>
>
> In LB there is randomAssignment(List<ServerName servers>) API which will be
> used by AM to assign
> a region from a down RS. [This will be also used in other cases like call to
> assign() API from client]
> I feel it would be better to pass the HRegionInfo also into this method.
> When the LB making a choice for a region
> assignment, when one RS is down, it would be nice that the LB knows for
> which region it is doing this server selection.
> +Scenario+
> While one RS down, we wanted the regions to get moved to other RSs but a set
> of regions stay together. We are having custom load balancer but with the
> current way of LB interface this is not possible. Another way is I can allow
> a random assignment of the regions at the RS down time. Later with a cluster
> balance I can balance the regions as I need. But this might make regions
> assign 1st to one RS and then again move to another. Also for some time
> period my business use case can not get satisfied.
> Also I have seen some issue in JIRA which speaks about making sure that Root
> and META regions always sit in some specific RSs. With the current LB API
> this wont be possible in future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
