[ 
https://issues.apache.org/jira/browse/HBASE-21258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634790#comment-16634790
 ] 

Andrew Purtell commented on HBASE-21258:
----------------------------------------

I committed 21258.v1.txt amended with the removal of a handful of asserts that 
have not been testing what they think they are testing, as revealed by the 
21258.v1.txt change. These asserts are incidental to what is being tested by 
the respective units. I'm not happy with this but more substantial changes 
should have a separate followup. TestRSGroups should be rewritten to avoid 
catch-all initialization and cleanup steps in @before and @after methods. It 
also has a running time of 230 seconds. Could stand to be split up 8 ways (or 
more). 

This unblocks HBASE-21117, proceeding there. 

> Add resetting of flags for RS Group pre/post hooks in TestRSGroups
> ------------------------------------------------------------------
>
>                 Key: HBASE-21258
>                 URL: https://issues.apache.org/jira/browse/HBASE-21258
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.8
>
>         Attachments: 21258.branch-1.04.txt, 21258.branch-1.05.txt, 
> 21258.branch-2.v1.patch, 21258.v1.txt
>
>
> Over HBASE-20627, [~xucang] reminded me that the resetting of flags for RS 
> Group pre/post hooks in TestRSGroups was absent.
> This issue is to add the resetting of these flags before each subtest starts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to