[
https://issues.apache.org/jira/browse/HBASE-21258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634768#comment-16634768
]
Andrew Purtell edited comment on HBASE-21258 at 10/2/18 12:07 AM:
------------------------------------------------------------------
I seem to have looked at "21258.v1.txt" but this was not what was proposed for
commit to branch-1 or what was committed there. I have objection to what was
committed. It in effect clones TestRSGroups, but ignores all of its tests, and
adds two more. This isn't the way it should be done. Shouldn't have to explain
why, but if you need it, just consider what ignoring 22 units looks like in
junit output... unnecessarily suspicious. Also, if anyone adds a test to
TestRSGroups but fails to add an @ignore in TestRSGroups1 whoops the new test
runs twice. We don't need this "TestRSGroups1" thing anyway. I will replace the
branch-1 commit with what I expected, a port of 21258.v1.txt to branch-1.
was (Author: apurtell):
I seem to have looked at "21258.v1.txt" but this was not what was proposed for
commit to branch-1 or what was committed there. I have objection to what was
committed. It in effect clones TestRSGroups, but ignores all of its tests, and
adds two more. This isn't the way it should be done. Shouldn't have to explain
why, but if you need it, just consider what ignoring 22 units looks like in
junit output... unnecessarily, suspicious. We don't need this "TestRSGroups1"
thing anyway. I will replace the branch-1 commit with what I expected, a port
of 21258.v1.txt to branch-1.
> Add resetting of flags for RS Group pre/post hooks in TestRSGroups
> ------------------------------------------------------------------
>
> Key: HBASE-21258
> URL: https://issues.apache.org/jira/browse/HBASE-21258
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.8
>
> Attachments: 21258.branch-1.04.txt, 21258.branch-1.05.txt,
> 21258.branch-2.v1.patch, 21258.v1.txt
>
>
> Over HBASE-20627, [~xucang] reminded me that the resetting of flags for RS
> Group pre/post hooks in TestRSGroups was absent.
> This issue is to add the resetting of these flags before each subtest starts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
