[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637615#comment-16637615
]
Andrew Purtell edited comment on HBASE-21265 at 10/3/18 11:41 PM:
------------------------------------------------------------------
Here's a patch for branch-1. It's a simple refactor. I just moved test units
around. Patch for master and later branches would follow the same approach.
When run in suite, results look approximately like this now:
{noformat}
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.715
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 103.974
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 68.73 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.154 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.288 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.844 s
- in org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.899 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.817 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.622 s
- in
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.874 s
- in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 43, Failures: 0, Errors: 0, Skipped: 0
{noformat}
was (Author: apurtell):
Here's a patch for branch-1. Patch for master and later branches would follow
the same approach. When run in suite, results look approximately like this now:
{noformat}
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.715
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 103.974
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 68.73 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.154 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.288 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.844 s
- in org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.899 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.817 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.622 s
- in
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.874 s
- in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 43, Failures: 0, Errors: 0, Skipped: 0
{noformat}
> Split up TestRSGroups
> ---------------------
>
> Key: HBASE-21265
> URL: https://issues.apache.org/jira/browse/HBASE-21265
> Project: HBase
> Issue Type: Task
> Components: rsgroup, test
> Affects Versions: 1.4.8
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Minor
> Labels: beginner, beginners
> Fix For: 3.0.0, 1.5.0, 2.2.0
>
> Attachments: HBASE-21265-branch-1.patch
>
>
> TestRSGroups is flaky. It is stable when run in isolation but when run as
> part of the suite with concurrent executors it can fail. The current running
> time of this unit on my dev box is ~240 seconds (4 minutes), which is far too
> much time. This unit should be broken up 5 to 8 ways, grouped by
> functionality under test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
