[
https://issues.apache.org/jira/browse/HBASE-20782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639899#comment-16639899
]
Jan Hentschel commented on HBASE-20782:
---------------------------------------
[~xucang] Looks good so far. Four minor points:
# Please log out the IOException in {{HttpServerFunctionalTest#access}}.
# Is it possible to use automatic resource management in the {{access}} method?
# Remove the two empty lines above the class definition of {{TestGlobalFilter}}.
# Remove the empty lines above {{TestPathFilter#testPathSpecFilters}}.
> Fix duplication of TestServletFilter.access
> -------------------------------------------
>
> Key: HBASE-20782
> URL: https://issues.apache.org/jira/browse/HBASE-20782
> Project: HBase
> Issue Type: Improvement
> Reporter: Jan Hentschel
> Assignee: Xu Cang
> Priority: Minor
> Attachments: HBASE-20782.master.001.patch,
> HBASE-20782.master.002.patch, HBASE-20782.master.003.patch,
> HBASE-20782.master.003.patch, HBASE-20782.master.003.patch,
> HBASE-20782.master.003.patch
>
>
> The {{access}} method in {{TestServletFilter}} is duplicated in
> {{TestPathFilter}}. The method should be moved into a common place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
