[
https://issues.apache.org/jira/browse/HBASE-21263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642216#comment-16642216
]
Andrew Purtell commented on HBASE-21263:
----------------------------------------
This change is fine, but is it the only place we log storefile details? Perhaps
you can do a search over the code looking for other places? If it were me I'd
load up the sources in eclipse, my preferred ide maybe you have another, and
would step through occurrences of calls for <log type>.debug and <log
type>.info in at least all files under
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile but ideally also
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver
> Mention compression algorithm along with other storefile details
> ----------------------------------------------------------------
>
> Key: HBASE-21263
> URL: https://issues.apache.org/jira/browse/HBASE-21263
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Subrat Mishra
> Priority: Minor
> Labels: beginner, beginners
> Attachments: HBASE-21263.master.001.patch,
> HBASE-21263.master.002.patch
>
>
> Where we log storefile details we should also log the compression algorithm
> used to compress blocks on disk, if any.
> For example, here's a log line out of compaction:
> 2018-10-02 21:59:47,594 DEBUG
> [regionserver/host/1.1.1.1:8120-longCompactions-1538517461152]
> compactions.Compactor: Compacting
> hdfs://namenode:8020/hbase/data/default/TestTable/86037c19117a46b5b8148439ea55753b/i/3d04a7c28d6343ceb773737dbb192533,
> keycount=3335873, bloomtype=ROW, size=107.5 M, encoding=ROW_INDEX_V1,
> seqNum=154199, earliestPutTs=1538516084915
> Aside from bloom type, block encoding, and filename, it would be good to know
> compression type in this type of DEBUG or INFO level logging. A minor
> omission of information that could be helpful during debugging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
