[ https://issues.apache.org/jira/browse/HBASE-21256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642836#comment-16642836 ]
Hadoop QA commented on HBASE-21256: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 14s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 59s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 22s{color} | {color:red} hbase-it in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 22s{color} | {color:red} hbase-it in the patch failed. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 23s{color} | {color:red} hbase-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s{color} | {color:red} hbase-it: The patch generated 1 new + 40 unchanged - 0 fixed = 41 total (was 40) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 1m 2s{color} | {color:red} patch has 11 errors when building our shaded downstream artifacts. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 47s{color} | {color:red} The patch causes 11 errors with Hadoop v2.7.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 39s{color} | {color:red} The patch causes 11 errors with Hadoop v3.0.0. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 44s{color} | {color:red} hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 18s{color} | {color:red} hbase-common in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 22s{color} | {color:red} hbase-it in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 20m 56s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-common | | | Boxing/unboxing to parse a primitive org.apache.hadoop.hbase.util.Random64.main(String[]) At Random64.java:org.apache.hadoop.hbase.util.Random64.main(String[]) At Random64.java:[line 100] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21256 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12942959/HBASE-21256-v10.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1f0f8b5c428e 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / c9213f752e | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-compile-hbase-it.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-compile-hbase-it.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/diff-checkstyle-hbase-common.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/diff-checkstyle-hbase-it.txt | | shadedjars | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-javac-2.7.4.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-javac-3.0.0.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-unit-hbase-common.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/artifact/patchprocess/patch-unit-hbase-it.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/testReport/ | | Max. process+thread count | 87 (vs. ulimit of 10000) | | modules | C: hbase-common hbase-it U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14602/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Improve IntegrationTestBigLinkedList for testing huge data > ---------------------------------------------------------- > > Key: HBASE-21256 > URL: https://issues.apache.org/jira/browse/HBASE-21256 > Project: HBase > Issue Type: Improvement > Components: integration tests > Affects Versions: 3.0.0 > Reporter: Zephyr Guo > Assignee: Zephyr Guo > Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21256-v1.patch, HBASE-21256-v10.patch, > HBASE-21256-v2.patch, HBASE-21256-v3.patch, HBASE-21256-v4.patch, > ITBLL-1.png, ITBLL-2.png > > > Recently, I use ITBLL to test some features in our company. I have > encountered the following problems: > > 1. Generator is too slow at the generating stage, the root cause is > SecureRandom. There is a global lock in SecureRandom( See the following > picture). I use Random instead of SecureRandom, and it could speed up this > stage(500% up with 20 mapper). SecureRandom was brought by HBASE-13382, but > speaking of generating random bytes, in my opnion, > it is the same with Random. > !ITBLL-1.png! > 2. VerifyReducer have a cpu cost of 14% on format method. This is cause by > create keyString variable. However, keyString may never be used if test > result is correct.(and that's in most cases). Just delay creating keyString > can yield huge performance boost in verifing stage. > !ITBLL-2.png! > 3.Arguments check is needed, because there's constraint between arguments. If > we broken this constraint, we can not get a correct circular list. > > 4.Let big family value size could be configured. > > 5.Avoid starting RS at backup master -- This message was sent by Atlassian JIRA (v7.6.3#76005)