[ 
https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644810#comment-16644810
 ] 

maoling commented on HBASE-20623:
---------------------------------

[~chia7712]

1.look at the flaky test shown in the 006 and 007 patch.It seems to be not 
related.

2.??Could you add tests against checking the "type" and "row" of cell built by 
CellBuilder??
 the cell doesn't have a *getRow* method for me to assert,so in the UT, I 
cell.setRow(Bytes.toBytes("123")) and get no this row to check setRow is 
useless.WDYT?

> Introduce the helper method "getCellBuilder()" to Mutation
> ----------------------------------------------------------
>
>                 Key: HBASE-20623
>                 URL: https://issues.apache.org/jira/browse/HBASE-20623
>             Project: HBase
>          Issue Type: Task
>          Components: API
>            Reporter: Chia-Ping Tsai
>            Assignee: maoling
>            Priority: Minor
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-20623.master.001.patch, 
> HBASE-20623.master.002.patch, HBASE-20623.master.003.patch, 
> HBASE-20623.master.004.patch, HBASE-20623.master.005.patch, 
> HBASE-20623.master.006.patch, HBASE-20623.master.007.patch
>
>
> see 
> [https://lists.apache.org/thread.html/d05bfaa0134502a47f6e1aca56cb0b096d4dd32ddefbbdf28db4952a@%3Cdev.hbase.apache.org%3E]
>  for more details.
> {code:java}
> How about a "getCellBuilder" or "getCellBuilderFactory" method for
> Mutation implementations that gives you a CellBuilder instance that
> already has relevant parts set? Like for a Put instance it should be
> able to already have the Type and Row set.{code}
> mentioned a day or so ago by [~busbey]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to