[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645331#comment-16645331
]
Josh Elser commented on HBASE-21246:
------------------------------------
{code:java}
+ /**
+ * Starting time of the wal which help in sorting against the others
+ * @return start time of the wal
+ */
+ long getWalStartTime();{code}
Why isn't this a {{WALProvider}} method?
{code:java}
+ /**
+ * For the FS based path, it will be just a filename of whole path
+ * For stream based, it will be name of the stream
+ * @return name of the wal
+ */
+ String getName();{code}
This should be stating what this method needs to do (so custom WAL providers
know how to implement it). Like WALIdentity is uniquely identifying a WAL
stored in this WALProvider, this name can be thought of as a human-readable,
serialized form of the WALIdentity. Making sure that developers know that this
needs to be unique/stable is important.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Attachments: 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
