[ 
https://issues.apache.org/jira/browse/HBASE-21251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647851#comment-16647851
 ] 

Guanghao Zhang commented on HBASE-21251:
----------------------------------------

We used this tool in our cluster but the cliend side time of moving one region 
is 10 seconds. I didn't use a profiling tool to analyze why it is too slow... 
Just read the code and refactor. And I test the new implemeantion in our 
cluster. The time of moving one region reduced from 10 seconds to 0.6 seconds...

> Refactor RegionMover
> --------------------
>
>                 Key: HBASE-21251
>                 URL: https://issues.apache.org/jira/browse/HBASE-21251
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0, 2.1.1
>
>         Attachments: HBASE-21251.master.001.patch, 
> HBASE-21251.master.002.patch, HBASE-21251.master.003.patch, 
> HBASE-21251.master.004.patch
>
>
> 1. Move connection and admin to RegionMover's member variables. No need 
> create connection many times.
> 2. use try-with-resource to reduce code
> 3. use ServerName instead of String
> 4. don't use Deprecated method
> 5. remove duplicate code
> ......



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to