[
https://issues.apache.org/jira/browse/HBASE-21266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648132#comment-16648132
]
stack commented on HBASE-21266:
-------------------------------
I just ran into this testing tip of branch-2.1
Patch looks good to me.
Are the check for logging level and avoidance of interpolation because this a
branch-1 patch? e.g.
161 if (LOG.isDebugEnabled()) {
162 LOG.debug("Removing old instance of server from
processingServers set: " + sn +
163 " (numProcessing=" + processingServers.size() + ")");
164 }
Any value in checking the add/remove to set return values? If only to log?
> Not running balancer because processing dead regionservers, but empty dead rs
> list
> ----------------------------------------------------------------------------------
>
> Key: HBASE-21266
> URL: https://issues.apache.org/jira/browse/HBASE-21266
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.4.8
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Major
> Fix For: 1.5.0, 1.4.9
>
> Attachments: HBASE-21266-branch-1.patch, HBASE-21266-branch-1.patch,
> HBASE-21266-branch-1.patch, HBASE-21266-branch-1.patch,
> HBASE-21266-branch-1.patch, HBASE-21266-branch-1.patch,
> HBASE-21266-branch-1.patch, HBASE-21266-branch-1.patch,
> HBASE-21266-branch-1.patch
>
>
> Found during ITBLL testing. AM in master gets into a state where manual
> attempts from the shell to run the balancer always return false and this is
> printed in the master log:
> 2018-10-03 19:17:14,892 DEBUG
> [RpcServer.default.FPBQ.Fifo.handler=21,queue=0,port=8100] master.HMaster:
> Not running balancer because processing dead regionserver(s):
> Note the empty list.
> This errant state did not recover without intervention by way of master
> restart, but the test environment was chaotic so needs investigation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
