[ 
https://issues.apache.org/jira/browse/HBASE-21323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656209#comment-16656209
 ] 

Duo Zhang commented on HBASE-21323:
-----------------------------------

Oh I mean we can revert the patch first to make the build clean. And then let's 
try to find out the reason why branch-2.1 and branch-2.0 have a different 
behavior before re apply the patch here.

We will delete all the sub procedures at once when the root procedure is 
finished, and in this test, the root procedure is hung, so the DummyProcedure, 
which is a sub procedures, should not be purged... You can apply the patch to 
branch-2.1 or branch-2.0, and add some breakpoints in the loadProcedures method 
of ProcedureExecutor to see what's going on.

Thanks.

> Should not skip force updating for a sub procedure even if it has been 
> finished
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-21323
>                 URL: https://issues.apache.org/jira/browse/HBASE-21323
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0, 2.1.1, 2.0.3
>
>         Attachments: 
> 0001-HBASE-21323-Should-not-skip-force-updating-for-a-sub.ADDENDUM.patch, 
> HBASE-21323.patch, HBASE-21323.patch
>
>
> Keep seeing this
> {noformat}
> 2018-10-16,20:03:02,027 WARN [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: procedure 
> WALs count=340 above the warning threshold 10. check running procedures to 
> see if something is stuck.
> 2018-10-16,20:03:02,027 INFO [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: Rolled new 
> Procedure Store WAL, id=343
> 2018-10-16,20:03:02,027 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=991, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:02,027 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=992, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:02,027 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=994, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:02,027 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=995, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:02,870 WARN [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: procedure 
> WALs count=341 above the warning threshold 10. check running procedures to 
> see if something is stuck.
> 2018-10-16,20:03:02,870 INFO [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: Rolled new 
> Procedure Store WAL, id=344
> 2018-10-16,20:03:02,870 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=991, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:02,870 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=992, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:02,870 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=994, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:02,870 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=995, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:03,816 WARN [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: procedure 
> WALs count=342 above the warning threshold 10. check running procedures to 
> see if something is stuck.
> 2018-10-16,20:03:03,816 INFO [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: Rolled new 
> Procedure Store WAL, id=345
> 2018-10-16,20:03:03,816 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=991, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:03,816 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=992, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:03,816 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=994, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> 2018-10-16,20:03:03,816 DEBUG [Force-Update-PEWorker-0] 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Procedure pid=995, 
> ppid=990, state=SUCCESS; 
> org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure has already 
> been finished, skip force updating.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to