[
https://issues.apache.org/jira/browse/HBASE-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223522#comment-13223522
]
Zhihong Yu commented on HBASE-5516:
-----------------------------------
Can test results be described here ?
{code}
+ if (this.compressAlgo.equals(Compression.Algorithm.GZ) && blockBegin >
0) {
+ blockBegin -= HEADER_SIZE;
+ }
{code}
What if blockBegin is > 0 but less than HEADER_SIZE ?
{code}
+ if (compressionBos == null) {
+ if (this.compressAlgo.equals(Compression.Algorithm.GZ)) {
+ createCompressionStream();
+ }
+ }
{code}
The nested if statements can be condensed into one if statement.
> GZip leading to memory leak in 0.90. Fix similar to HBASE-5387 needed for
> 0.90.
> --------------------------------------------------------------------------------
>
> Key: HBASE-5516
> URL: https://issues.apache.org/jira/browse/HBASE-5516
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.5
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.7
>
> Attachments: HBASE-5516_2_0.90.patch
>
>
> Usage of GZip is leading to resident memory leak in 0.90.
> We need to have something similar to HBASE-5387 in 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
