[
https://issues.apache.org/jira/browse/HBASE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223523#comment-13223523
]
stack commented on HBASE-5533:
------------------------------
Did you mean the below:
{code}
-# hbase.class=org.apache.hadoop.hbase.metrics.file.TimeStampingFileContext
-# hbase.period=10
-# hbase.fileName=/tmp/metrics_hbase.log
+hbase.class=org.apache.hadoop.hbase.metrics.file.TimeStampingFileContext
+hbase.period=10
+hbase.fileName=/tmp/metrics_hbase.log
{code}
Will there be a bunch of contention on these additions:
{code}
+ static volatile BlockingQueue<Long> fsReadLatenciesNanos = new
ArrayBlockingQueue<Long>(LATENCY_BUFFER_SIZE);
{code}
Could this fill the logs with thousands of repeated messages:
{code}
+ if (!stored) {
+ LOG.warn("Dropping fs latency stat since buffer is full");
+ }
{code}
Could we use the cliff click counters instead of AtomicLong? They are on the
classpath IIRC:
{code}
+ private final Map<String, AtomicLong> counts;
{code}
These additions would be great to have.
> Add more metrics to HBase
> -------------------------
>
> Key: HBASE-5533
> URL: https://issues.apache.org/jira/browse/HBASE-5533
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Shaneal Manek
> Assignee: Shaneal Manek
> Priority: Minor
> Attachments: hbase-5533-0.92.patch
>
>
> To debub/monitor production clusters, there are some more metrics I wish I
> had available.
> In particular:
> - Although the average FS latencies are useful, a 'histogram' of recent
> latencies (90% of reads completed in under 100ms, 99% in under 200ms, etc)
> would be more useful
> - Similar histograms of latencies on common operations (GET, PUT, DELETE)
> would be useful
> - Counting the number of accesses to each region to detect hotspotting
> - Exposing the current number of HLog files
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
