[
https://issues.apache.org/jira/browse/HBASE-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223616#comment-13223616
]
Phabricator commented on HBASE-5521:
------------------------------------
mbautin has commented on the revision "HBASE-5521 [jira] Move
compression/decompression to an encoder specific encoding context".
Yongqiang: thanks for addressing the comments. I will take another pass
through the new version diff.
Could you please use a consistent abbreviation for "context"? Either Ctx or
Cxt, but not both.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:53
HFileDataBlockEncoder is actually aware of on-disk and in-cache encoding. The
on-disk encoding may be disabled when in-cache encoding is enabled, but not the
other way. The current code apparently did not need to explicitly store
encoding type in EncodedDataBlock (which is mostly used for testing and
benchmarking), and I am wondering why you need to store it now.
REVISION DETAIL
https://reviews.facebook.net/D2097
> Move compression/decompression to an encoder specific encoding context
> ----------------------------------------------------------------------
>
> Key: HBASE-5521
> URL: https://issues.apache.org/jira/browse/HBASE-5521
> Project: HBase
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HBASE-5521.1.patch, HBASE-5521.D2097.1.patch,
> HBASE-5521.D2097.2.patch
>
>
> As part of working on HBASE-5313, we want to add a new columnar
> encoder/decoder. It makes sense to move compression to be part of
> encoder/decoder:
> 1) a scanner for a columnar encoded block can do lazy decompression to a
> specific part of a key value object
> 2) avoid an extra bytes copy from encoder to hblock-writer.
> If there is no encoder specified for a writer, the HBlock.Writer will use a
> default compression-context to do something very similar to today's code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
