[ 
https://issues.apache.org/jira/browse/HBASE-21336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658482#comment-16658482
 ] 

Allan Yang commented on HBASE-21336:
------------------------------------

{quote}
 if it has no sub procedures. But now I sort the procedures so the parent 
procedure will arrive at first then the test will always pass and then we will 
set it to RUNNABLE...
{quote}
Do you remember I sent you some logs on Wechat? I encountered a case that a 
parent procedure executed first even there are children procedures. And later 
the children procedures began to execute but only find its parent gone. It may 
have something to do with these logic, may have bug in it...
{code}
2018-10-10 14:38:08,662 DEBUG [PEWorker-2] procedure2.ProcedureExecutor(1451): 
LOCK_EVENT_WAIT pid=15, ppid=14, state=RUNNABLE:REGION_TRANSITION_QUEUE, 
hasLock=false; AssignProcedure table=hbase:acl, 
region=267335c85766c62479fb4a5f18a1e95f
2018-10-10 14:38:08,964 INFO  [PEWorker-1] procedure2.ProcedureExecutor(1461): 
Finished pid=14, state=SUCCESS, hasLock=false; ServerCrashProcedure 
server=hb-uf6oyi699w8h700f0-003,16020,1539076734964, splitWal=true, meta=false 
in 3mins, 18.934sec
2018-10-10 14:38:13,699 WARN  [PEWorker-3] procedure2.ProcedureExecutor(1385): 
Rollback because parent is done/rolledback proc=pid=15, ppid=14, 
state=RUNNABLE:REGION_TRANSITION_QUEUE, hasLock=false; AssignProcedure 
table=hbase:acl, region=267335c85766c62479fb4a5f18a1e95f
{code} 

> Simplify the implementation of WALProcedureMap
> ----------------------------------------------
>
>                 Key: HBASE-21336
>                 URL: https://issues.apache.org/jira/browse/HBASE-21336
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-21336-v1.patch, HBASE-21336-v2.patch, 
> HBASE-21336-v3.patch, HBASE-21336.patch
>
>
> I do not think we need to implement the logic from such a low level, i.e, 
> building complicated linked list by hand, which makes it really hard to 
> understand.
> Let me try to implement it with existing data structures...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to