[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659991#comment-16659991
]
Josh Elser edited comment on HBASE-21246 at 10/23/18 3:03 AM:
--------------------------------------------------------------
{quote}
> Why do we have a String constructor anyways?
createWALIdentity() ends up calling FSWALIdentity ctor accepting String (when
WAL is backed by hdfs).
{quote}
I don't understand why you're telling me this. I could look at the wal-refactor
code if I wanted to know who called it. I am asking you why this HDFS-based
implementation for a WAL is using anything other than a {{Path}} to refer to a
WAL.
The question (worry) in-between the lines is: do we have references to WALs
other than by Path? Looking at {{master}}, the original code from
ReplicationSourceManager was using Path.
was (Author: elserj):
{quote}{quote}Why do we have a String constructor anyways?
{quote}
createWALIdentity() ends up calling FSWALIdentity ctor accepting String (when
WAL is backed by hdfs).
{quote}
I don't understand why you're telling me this. I could look at the wal-refactor
code if I wanted to know who called it. I am asking you why this HDFS-based
implementation for a WAL is using anything other than a {{Path}} to refer to a
WAL.
The question (worry) in-between the lines is: do we have references to WALs
other than by Path? Looking at {{master}}, the original code from
ReplicationSourceManager was using Path.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.HBASE-20952.001.patch,
> 21246.HBASE-20952.002.patch, 21246.HBASE-20952.004.patch,
> 21246.HBASE-20952.005.patch, 21246.HBASE-20952.007.patch,
> 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
