[ 
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664407#comment-16664407
 ] 

stack commented on HBASE-21322:
-------------------------------

Took a look at the patch. If an operator wants to schedule a SCP, why not just 
do it? You have all this checking for -splitting. Maybe there is some aspect of 
SCP that they need that does not involve WALs... some cleanup of master state 
or something? Just let the SCP go through? IIRC, it is able to handle case of 
many SCPs on the one server.

Otherwise, the patch looks good. Thanks [~tianjingyun]

> Add a scheduleServerCrashProcedure() API to HbckService
> -------------------------------------------------------
>
>                 Key: HBASE-21322
>                 URL: https://issues.apache.org/jira/browse/HBASE-21322
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jingyun Tian
>            Assignee: Jingyun Tian
>            Priority: Major
>         Attachments: HBASE-21322.master.001.patch, 
> HBASE-21322.master.002.patch, Screenshot from 2018-10-17 13-35-58.png, 
> Screenshot from 2018-10-17 13-38-41.png, Screenshot from 2018-10-17 
> 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted, 
> it will lead to that no ServerCrashProcedure is scheduled. And restarting 
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually 
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to 
> HbckService, then add this API to HBCK2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to