[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669058#comment-16669058
]
stack commented on HBASE-21246:
-------------------------------
bq. But WAL system's architecture is not very clear, and api/class abstraction
which it is very important IMO is not clean enough, as well as the
relations/work flows between WALFactory/WAL/WALIdentity/WAL***.class. (Hoping
diagrams will help!)
bq. However, we are so eager to taste the fruit of the WAL system that had
started quickly and bumps into a lot of details at the beginning which i doubt
it is a good thing.
bq. What about just introducing WALIdentity interface and implementing related
abstract classes with some TestMockImpl(or TestFSBasedImpl) to show what apis
looks like, rather than embedding into code base immediately, it may help us
discussions, reviews and collating with the design docs.
That sounds like a sensible approach (including diagrams bit.. ). [~reidchan]
doing it doesn't seem right though.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt,
> 21246.23.txt, 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch,
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch,
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
