[
https://issues.apache.org/jira/browse/HBASE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224899#comment-13224899
]
Zhihong Yu commented on HBASE-5213:
-----------------------------------
The approach is good.
Formatting needs to improve in several places. Such as:
{code}
+ if(!clusterStatusTracker.isClusterUp()) {
+ this.master.stop("Cluster went down before this master became active");
+ }
{code}
A space should be added between if and (
Indentation is a little off.
{code}
+ * Copyright 2012 The Apache Software Foundation
{code}
No year is needed above.
> "hbase master stop" does not bring down backup masters
> ------------------------------------------------------
>
> Key: HBASE-5213
> URL: https://issues.apache.org/jira/browse/HBASE-5213
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5213-v0-trunk.patch
>
>
> Typing "hbase master stop" produces the following message:
> "stop Start cluster shutdown; Master signals RegionServer shutdown"
> It seems like backup masters should be considered part of the cluster, but
> they are not brought down by "hbase master stop".
> "stop-hbase.sh" does correctly bring down the backup masters.
> The same behavior is observed when a client app makes use of the client API
> HBaseAdmin.shutdown()
> http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html#shutdown()
> -- this isn't too surprising since I think "hbase master stop" just calls
> this API.
> It seems like HBASE-1448 address this; perhaps there was a regression?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
