[
https://issues.apache.org/jira/browse/HBASE-21314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675100#comment-16675100
]
Allan Yang commented on HBASE-21314:
------------------------------------
{code}
- return Math.abs(procId - start) < MAX_NODE_SIZE;
{code}
Why not use abs?
Can you add a comment in isDeleted and isModified here:
{code}
modified[wordIndex] & (1L << bitmapIndex)
{code}
We all are confused about the left shift before( which can more than 64 times)
The patch looks good to me.
> The implementation of BitSetNode is not efficient
> -------------------------------------------------
>
> Key: HBASE-21314
> URL: https://issues.apache.org/jira/browse/HBASE-21314
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21314.patch, HBASE-21314.patch
>
>
> As the MAX_NODE_SIZE is the same with BITS_PER_WORD, which means that we
> could only have one word(long) for each BitSetNode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
