[ 
https://issues.apache.org/jira/browse/HBASE-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225340#comment-13225340
 ] 

Phabricator commented on HBASE-5515:
------------------------------------

sc has commented on the revision "HBASE-5515 [jira] Add a processRow API that 
supports atomic multiple reads and writes on a row".

  I tried making ProcessorRowEnpoint endpoint an abstract class. The difficulty 
is that when creating ProcessRowProtocal you can not pass parameter in the 
constructor. So the parameter has to be passed by the actually processRow() 
call. You can use generic

  ProcessRowProtocol {
  <T, S> T processRow(S input);
  }

  But this is kind of ugly. And you will need to have the actual S in the class 
path also. This is not good for the same reason you don't what RowProcessor as 
a separate class.

  So I just leave the users to do their own CoprocessorProtocol and 
CoprocessorEndpoint just like the example in the unit test.

REVISION DETAIL
  https://reviews.facebook.net/D2067

                
> Add a processRow API that supports atomic multiple reads and writes on a row
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-5515
>                 URL: https://issues.apache.org/jira/browse/HBASE-5515
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: HBASE-5515.D2067.1.patch, HBASE-5515.D2067.10.patch, 
> HBASE-5515.D2067.11.patch, HBASE-5515.D2067.12.patch, 
> HBASE-5515.D2067.13.patch, HBASE-5515.D2067.14.patch, 
> HBASE-5515.D2067.15.patch, HBASE-5515.D2067.16.patch, 
> HBASE-5515.D2067.17.patch, HBASE-5515.D2067.18.patch, 
> HBASE-5515.D2067.19.patch, HBASE-5515.D2067.2.patch, 
> HBASE-5515.D2067.20.patch, HBASE-5515.D2067.3.patch, 
> HBASE-5515.D2067.4.patch, HBASE-5515.D2067.5.patch, HBASE-5515.D2067.6.patch, 
> HBASE-5515.D2067.7.patch, HBASE-5515.D2067.8.patch, HBASE-5515.D2067.9.patch
>
>
> We have modified HRegion.java internally to do some atomic row processing. It 
> will be nice to have a plugable API for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to