[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680048#comment-16680048 ]
Ted Yu commented on HBASE-21457: -------------------------------- bq. can you replace filesystem parameter fs with walFs in the lines above? Done in patch v2. bq. confirm child classes of TestBackupBase passed ? Verified locally - all backup tests passed. I will see if I can add a unit test. Janos will run tests with local HDFS for WALs which would verify the fix. > BackupUtils#getWALFilesOlderThan refers to wrong FileSystem > ----------------------------------------------------------- > > Key: HBASE-21457 > URL: https://issues.apache.org/jira/browse/HBASE-21457 > Project: HBase > Issue Type: Bug > Reporter: Janos Gub > Assignee: Ted Yu > Priority: Major > Attachments: 21457.v1.txt, 21457.v2.txt > > > Janos reported seeing backup test failure when testing a local HDFS for WALs > while using WASB/ADLS only for store files. > Janos spotted the code in BackupUtils#getWALFilesOlderThan which uses HBase > root dir for retrieving WAL files. > We should use the helper methods from CommonFSUtils. -- This message was sent by Atlassian JIRA (v7.6.3#76005)