[
https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684656#comment-16684656
]
Tak Lon (Stephen) Wu commented on HBASE-21457:
----------------------------------------------
+1 (non-binding) with a trivial comment
{quote}
+ LOG.debug("setting waldir " + p + " root2: " + root2);
{quote}
[trivial] please consider remove the debug line above
[~yuzhih...@gmail.com] thanks for fixing the bug in HBASE-21466 and fixing the
unit tests in this JIRA :).
> BackupUtils#getWALFilesOlderThan refers to wrong FileSystem
> -----------------------------------------------------------
>
> Key: HBASE-21457
> URL: https://issues.apache.org/jira/browse/HBASE-21457
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Janos Gub
> Assignee: Ted Yu
> Priority: Major
> Attachments: 21457.v1.txt, 21457.v2.txt, 21457.v3.txt, 21457.v3.txt,
> 21457.v4.txt
>
>
> Janos reported seeing backup test failure when testing a local HDFS for WALs
> while using WASB/ADLS only for store files.
> Janos spotted the code in BackupUtils#getWALFilesOlderThan which uses HBase
> root dir for retrieving WAL files.
> We should use the helper methods from CommonFSUtils.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
