[
https://issues.apache.org/jira/browse/HBASE-21141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689701#comment-16689701
]
Ted Yu commented on HBASE-21141:
--------------------------------
We're close.
{code}
+ // #3 - incremental backup for multiple tables
{code}
#3 is repeated. Do you mind re-numbering the steps so that it is easier to
follow ?
Please leave a blank line prior to each step for readability.
{code}
+ LOG.debug("mob has " + TEST_UTIL.countRows(hTable, mobName) + " rows");
+ Assert.assertEquals(TEST_UTIL.countRows(hTable, mobName), NB_ROWS_MOB);
{code}
countRows(hTable, mobName) is called twice - once for LOG and once for
assertion. Can you store the count in a variable so that counting is called
only once ?
Same applies to countRows(hTable, famName) and countRows(hTable, fam2Name).
> Enable MOB in backup / restore test involving incremental backup
> ----------------------------------------------------------------
>
> Key: HBASE-21141
> URL: https://issues.apache.org/jira/browse/HBASE-21141
> Project: HBase
> Issue Type: Test
> Components: backup&restore
> Reporter: Ted Yu
> Assignee: Artem Ervits
> Priority: Major
> Labels: mob
> Attachments: HBASE-21141.v01.patch, HBASE-21141.v02.patch
>
>
> Currently we only have one test (TestRemoteBackup) where MOB feature is
> enabled. The test only performs full backup.
> This issue is to enable MOB in backup / restore test(s) involving incremental
> backup.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
