[ 
https://issues.apache.org/jira/browse/HBASE-21490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690885#comment-16690885
 ] 

Duo Zhang commented on HBASE-21490:
-----------------------------------

UT to reproduce the problem.

And also found a typo in WALProcedureStore, forgot to update the tracker 
variable in the loop at the end of buildHoldingCleanupTracker...

> WALProcedure may remove proc wal files still with active procedures
> -------------------------------------------------------------------
>
>                 Key: HBASE-21490
>                 URL: https://issues.apache.org/jira/browse/HBASE-21490
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>            Reporter: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-21490-UT.patch
>
>
> It happens for me several times. After master restart, all the procedures are 
> gone.
> And the proc wal files were deleted before restarting, I see this in the 
> master's log
> {noformat}
> 2018-11-16,20:57:40,177 INFO [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: Remove all 
> state logs with ID less than 184, since all the active procedures are in the 
> latest log
> 2018-11-16,20:57:40,177 INFO [WALProcedureStoreSyncThread] 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFile: Archiving 
> hdfs://c4tst-xiaomi/hbase/c4tst-sync1/MasterProcWALs/pv2-00000000000000000184.log
>  to hdfs://c4tst-xiaomi/hbase/c4tst-sync1/oldWALs/pv2-00000000000000000184.log
> {noformat}
> Let me dig...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to