[
https://issues.apache.org/jira/browse/HBASE-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225769#comment-13225769
]
Hadoop QA commented on HBASE-5535:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517652/HBASE-5535-Make-the-functions-in-task-monitor-synchr-2012-03-08_16_33_42.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -123 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 159 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1141//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1141//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1141//console
This message is automatically generated.
> Make the functions in task monitor synchronized
> -----------------------------------------------
>
> Key: HBASE-5535
> URL: https://issues.apache.org/jira/browse/HBASE-5535
> Project: HBase
> Issue Type: Bug
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments:
> HBASE-5535-Make-the-functions-in-task-monitor-synchr-2012-03-08_16_33_42.patch
>
>
> There are some potential race condition in the task monitor. So update the
> functions in task monitor to be synchronized.
> The example of the problem caused by the race condition:
> ERROR org.apache.hadoop.hbase.regionserver.MemStoreFlusher: Cache flush
> failed for region
> java.lang.IndexOutOfBoundsException: Index: 1745, Size: 1744
> at java.util.ArrayList.add(ArrayList.java:367)
> at java.util.SubList.add(AbstractList.java:633)
> at java.util.SubList.add(AbstractList.java:633)
> at java.util.SubList.add(AbstractList.java:633)
> at java.util.SubList.add(AbstractList.java:633)
> at java.util.SubList.add(AbstractList.java:633)
> at java.util.AbstractList.add(AbstractList.java:91)
> at
> org.apache.hadoop.hbase.monitoring.TaskMonitor.createStatus(TaskMonitor.java:74)
> at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:1139)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:260)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:234)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.run(MemStoreFlusher.java:146)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
