[
https://issues.apache.org/jira/browse/HBASE-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702403#comment-16702403
]
Josh Elser commented on HBASE-18735:
------------------------------------
{quote}.02 patch addresses [~stack] comment as well as fixes some checkstyle
issues. There are over 7000 checkstyle issues in hbase-server and hundreds of
issues in HBaseTestingUtility alone, if need be, I can address those in a
separate jira.
{quote}
In general, HBase committers asks for separating out stylistic changes into
their own commit. If you're editing a line already, feel free to bring it up to
shape, but don't change style in a method that you didn't edit.
{quote}do I need to keep the tests as they're not testing but merely there for
timing purposes.
{quote}
I'd suggest dropping {{testShutdownMiniHBaseCluster}} but leaving
{{testKillMiniHBaseCluster}} there, just to exercise the new method you added.
> Provide a fast mechanism for shutting down mini cluster
> -------------------------------------------------------
>
> Key: HBASE-18735
> URL: https://issues.apache.org/jira/browse/HBASE-18735
> Project: HBase
> Issue Type: Wish
> Reporter: Samarth Jain
> Assignee: Artem Ervits
> Priority: Major
> Attachments: HBASE-18735.v01.patch, HBASE-18735.v02.patch
>
>
> The current mechanism of shutting down a mini cluster through
> HBaseTestingUtility.shutDownMiniCluster can take a lot of time when the mini
> cluster almost has a lot of tables. A lot of this time is spent in closing
> all the user regions. It would be nice to have a mechanism where this
> shutdown can happen quickly without having to worry about closing these user
> regions. At the same time, this mechanism would need to make sure that all
> the critical system resources like file handles and network ports are still
> released so that subsequently initialized mini clusters on the same JVM or
> system won't run into resource issues. This would make testing using HBase
> mini clusters much faster and immensely help out test frameworks of dependent
> projects like Phoenix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
