[
https://issues.apache.org/jira/browse/HBASE-21559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711538#comment-16711538
]
Zheng Hu commented on HBASE-21559:
----------------------------------
bq. But at t8, the TakeSnapshotHandler is already in the map right?
Think about the above case again, should be no problem if move the v!=null &
v.isFinished() out of the computeIfPresent. because the status of v will
transform from not finished to finished. if get a not finished state, then
the STRP won't process, it's OK even if someone change it from not finished to
finished.
bq. so the problem here is that the state should be volatile.
the state is volatile now.
> The RestoreSnapshotFromClientTestBase related UT are flaky
> ----------------------------------------------------------
>
> Key: HBASE-21559
> URL: https://issues.apache.org/jira/browse/HBASE-21559
> Project: HBase
> Issue Type: Bug
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Major
> Fix For: 3.0.0, 2.1.2, 2.0.4, 2.0.5
>
> Attachments: HBASE-21559.v1.patch,
> TEST-org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions.xml,
>
> org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions-output.txt,
>
> org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions.txt
>
>
> The related UT are:
> * TestRestoreSnapshotFromClientAfterSplittingRegions
> * TestRestoreSnapshotFromClientWithRegionReplicas
> * TestMobRestoreSnapshotFromClientAfterSplittingRegions
> I guess the main problem is: a dead lock between SplitTableRegionProcedure
> and SnapshotProcedure..
> Attached logs from the failed UT.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
