[ 
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226558#comment-13226558
 ] 

Zhihong Yu commented on HBASE-4608:
-----------------------------------

Thanks for the reminder w.r.t. Metadata.

In SequenceFileLogWriter.init(), we can pass Metadata, indicating whether WAL 
compression is enabled, to SequenceFile.Writer which then gets persisted.
SequenceFile.Reader.getMetadata() would return WAL compression status.

The we don't need the following in SequenceFileLogReader.init():
{code}
    compression = conf.getBoolean(HConstants.ENABLE_WAL_COMPRESSION, false);
{code}

I think the above is important part of the review comments.

Will address adding unit test too, maybe in later iteration.
                
> HLog Compression
> ----------------
>
>                 Key: HBASE-4608
>                 URL: https://issues.apache.org/jira/browse/HBASE-4608
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.94.0
>
>         Attachments: 4608-v19.txt, 4608v1.txt, 4608v13.txt, 4608v13.txt, 
> 4608v14.txt, 4608v15.txt, 4608v16.txt, 4608v17.txt, 4608v18.txt, 4608v5.txt, 
> 4608v6.txt, 4608v7.txt, 4608v8fixed.txt
>
>
> The current bottleneck to HBase write speed is replicating the WAL appends 
> across different datanodes. We can speed up this process by compressing the 
> HLog. Current plan involves using a dictionary to compress table name, region 
> id, cf name, and possibly other bits of repeated data. Also, HLog format may 
> be changed in other ways to produce a smaller HLog.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to