[ 
https://issues.apache.org/jira/browse/HBASE-21600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720844#comment-16720844
 ] 

Reid Chan commented on HBASE-21600:
-----------------------------------

Let me finish this trivial, since i bring this up.

> Investigate non-null check on FSWALIdentity
> -------------------------------------------
>
>                 Key: HBASE-21600
>                 URL: https://issues.apache.org/jira/browse/HBASE-21600
>             Project: HBase
>          Issue Type: Task
>            Reporter: Josh Elser
>            Priority: Trivial
>             Fix For: HBASE-20952
>
>
> {code:java}
> public FSWALIdentity(Path path) 
> public FSWALIdentity(String name)
> {code}
> bq. Can we add a pre-null check or annotation NotNullable or javadoc to raise 
> attention of no-null? Passing a null object to WALIdentity makes no sense to 
> me.
> Reid had the above suggestion on HBASE-21246. Should make a check throughout 
> the code and make sure nothing else breaks if we start asserting that the 
> path/name is always non-null (I fear something might :P).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to