[ 
https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721073#comment-16721073
 ] 

Y. SREENIVASULU REDDY commented on HBASE-21408:
-----------------------------------------------

Thanks for the review and comment [~stack]

>>>>>>>>What is this change about Y. SREENIVASULU REDDY ? 
If user configured hbase.wal.dir explicitly. Lets take an example of s3 
environment.
If trying to clean the whole hbase data using hbase cleanup scripts, It is 
missing to cleanup the path "hbase.wal.dir" path.
so this patch will clean all the data.

>>>>>>>>execute_zk_command "deleteall ${zparent}";
updated the ZK command. earlier "rmr ${zparent}" is using but "rmr" command is 
deprecated.


>>>>>>>>Should there be a space up there between hrootdir and hwaldir?
providing "$hrootdir $hwaldir" both the paths are assigning to "hrootdir", 
which make short to delete multiple paths in the hdfs.

>>>>>>>>Was hwaldir not being set?
In this case only hrootdir only we are deleting.

> Add hbase.wal.dir clean operation also to hbase cleanup script.
> ---------------------------------------------------------------
>
>                 Key: HBASE-21408
>                 URL: https://issues.apache.org/jira/browse/HBASE-21408
>             Project: HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 2.1.0
>            Reporter: Y. SREENIVASULU REDDY
>            Priority: Major
>             Fix For: 2.1.3
>
>         Attachments: HBASE-21408.001.patch
>
>
> If user configured hbase.wal.dir explicitly.
> cleaning scripts should handle this too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to