[ 
https://issues.apache.org/jira/browse/HBASE-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226779#comment-13226779
 ] 

Lars Hofhansl commented on HBASE-5520:
--------------------------------------

Agree with stack that the comment can be simplified. Also as stated in 
HBASE-2038, this reseek only works correctly on row boundaries, so the API 
should capture this and only accept a rowkey (rather than a KV).

Then maybe the comment could say something like this:
"Seek forward to the first KV matching the passed rowkey.
Only forward seeking is allowed, otherwise the behavior is undefined."

There might be problems with this approach too. What if the scanner already saw 
some KVs for this rowkey? It puts a lot of burden on the caller that we only 
seek forward.

As an aside:
Looking back at the various conversations, I actually have not heard a 
convincing argument on why using a Filter that returns the standard 
SEEK_NEXT_USING_HINT does not work. It would be doing a little bit more work 
(because each store would separately need to seek, and it needs to look at at 
least one more KV to decide to skip ahead), but that would still be *huge* win 
over a full scan that needs to look at every KV.
Filters do not have the above problems, since they are inherently per column 
family.
You wouldn't use filterRow() but use filterKeyValue() together with 
getNextKeyHint()
(see MultipleColumnPrefixFilter).

                
> Support reseek() at RegionScanner
> ---------------------------------
>
>                 Key: HBASE-5520
>                 URL: https://issues.apache.org/jira/browse/HBASE-5520
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.92.0
>            Reporter: Anoop Sam John
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5520_1.patch, HBASE-5520_2.patch
>
>
> reseek() is not supported currently at the RegionScanner level. We can 
> support the same.
> This is created following the discussion under HBASE-2038

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to