[ 
https://issues.apache.org/jira/browse/HBASE-21619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei-Chiu Chuang updated HBASE-21619:
------------------------------------
    Status: Patch Available  (was: Open)

Fixed the ternary operation and use slf4j parameterized logging for better 
readability.

> Fix warning message caused by incorrect ternary operator evaluation
> -------------------------------------------------------------------
>
>                 Key: HBASE-21619
>                 URL: https://issues.apache.org/jira/browse/HBASE-21619
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Trivial
>         Attachments: HBASE-21619.master.001.patch
>
>
> {code:title=LoadIncrementalHFiles#doBulkLoad}
> LOG.warn(
>           "Bulk load operation did not find any files to load in " + 
> "directory " + hfofDir != null
>               ? hfofDir.toUri().toString()
>               : "" + ".  Does it contain files in " +
>                   "subdirectories that correspond to column family names?");
> {code}
> JDK complains {{"Bulk load operation did not find any files to load in " + 
> "directory " + hfofDir != null}} is always true, which is not what is 
> intended, and that produces a wrong message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to