[ 
https://issues.apache.org/jira/browse/HBASE-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728098#comment-16728098
 ] 

Guanghao Zhang commented on HBASE-21631:
----------------------------------------

{code:java}
test_can_set_and_remove_quota(Hbase::SpaceQuotasTest)
src/test/ruby/hbase/quotas_test.rb:103:in `block in 
test_can_set_and_remove_quota'
100: command(:set_quota, TYPE => SPACE, LIMIT => '1G', POLICY => NO_INSERTS, 
TABLE => @test_name)
101: output = capture_stdout{ command(:list_quotas) }
102: size = 1024 * 1024 * 1024 
^[[48;5;124;38;5;231;1m => 103: assert(output.include?("LIMIT => #{size}"))^[[0m
104: assert(output.include?("VIOLATION_POLICY => NO_INSERTS"))
105: assert(output.include?("TYPE => SPACE"))
106: assert(output.include?("TABLE => #{@test_name}"))
{code}
TestQuotasShell is broken. [~jatsakthi] Can you attach an addendum patch to fix 
this? Thanks.

> list_quotas should print human readable values for LIMIT
> --------------------------------------------------------
>
>                 Key: HBASE-21631
>                 URL: https://issues.apache.org/jira/browse/HBASE-21631
>             Project: HBase
>          Issue Type: Improvement
>          Components: shell
>            Reporter: Sakthi
>            Assignee: Sakthi
>            Priority: Minor
>             Fix For: 3.0.0, 2.2.0, 2.1.2, 2.0.4
>
>         Attachments: hbase-21631.master.001.patch
>
>
> The list_quotas command should print human readable values for LIMIT. For 
> e.g. In the below case, printing LIMIT => 3G is better than printing LIMIT => 
> 3221225472
> {noformat}
> hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '3G', 
> POLICY => NO_WRITES
> Took 0.0132 seconds
> hbase(main):007:0> list_quotas
> OWNER                          QUOTAS
>  TABLE => t2                   TYPE => SPACE, TABLE => t2, LIMIT => 
> 3221225472, VIOLATION_POLICY => NO_WRITES
> 1 row(s)
> Took 0.0281 seconds
>  {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to