[ 
https://issues.apache.org/jira/browse/HBASE-21635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728191#comment-16728191
 ] 

Nihal Jain commented on HBASE-21635:
------------------------------------

Ok. So in future we should continue adding import bans at both places (to keep 
things in sync), or should we add import ban in appropriate place based on what 
we need to ban?

> Use maven enforcer to ban imports from illegal packages
> -------------------------------------------------------
>
>                 Key: HBASE-21635
>                 URL: https://issues.apache.org/jira/browse/HBASE-21635
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0, 2.1.2, 2.0.4
>
>         Attachments: HBASE-21635.patch
>
>
> Now we use checkstyle to report the illegal imports, but it will be easy to 
> be ignored by developpers.
> https://github.com/skuzzle/restrict-imports-enforcer-rule
> This is an extension for the maven enforcer plugin, which is used to ban 
> imports, and the advantage is that it will cause a compile error, which is 
> not likely to be ignored. The extension is not perfect, but I think it is 
> worth a try.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to