[ https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731760#comment-16731760 ]
Allan Yang commented on HBASE-21652: ------------------------------------ Thanks [~Apache9] for reviewing, V4 patch added two new UTs to test the thrift2 server as addressed in the review. Pending for QA. > Refactor ThriftServer making thrift2 server inherited from thrift1 server > ------------------------------------------------------------------------- > > Key: HBASE-21652 > URL: https://issues.apache.org/jira/browse/HBASE-21652 > Project: HBase > Issue Type: Sub-task > Reporter: Allan Yang > Assignee: Allan Yang > Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21652.patch, HBASE-21652.v2.patch, > HBASE-21652.v3.patch, HBASE-21652.v4.patch > > > Except the different protocol, thrift2 Server should have no much difference > from thrift1 Server. So refactoring the thrift server, making thrift2 server > inherit from thrift1 server. Getting rid of many duplicated code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)