[
https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734688#comment-16734688
]
Tak Lon (Stephen) Wu commented on HBASE-21457:
----------------------------------------------
The addendum looks good to me, although I went back and searched the master
branch and find more places needed to be addressed with WAL filesystem issue
(I'm mot sure if we'd like to address them in this JIRA).
Must fix with {{CommonFSUtils.getWALRootDir}} for *WAL root directory* with the
correct filesystem:
*
[org/apache/hadoop/hbase/util/HBaseFsck.java/HBaseFsck.java|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L1682-L1684]
*
[org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java#L315]
The following test classes also need some refactoring to use {{walFs}} or/and
{{CommonFSUtils.getWALRootDir}} to make it clear to operator to use WAL
filesystem, but it's fine because the setup was using the root file system for
both root directory and WAL directory.
*
[org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java#testSyncRunnerIndexOverflow|https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java#L105]
*
[org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java#testUnflushedSeqIdTracking|https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java#L148]
*
[org/apache/hadoop/hbase/fs/TestBlockReorderMultiBlocks.java|https://github.com/apache/hbase/blob/6dd5383033c5b0f84bd1de081a7fdadabe1658b8/hbase-server/src/test/java/org/apache/hadoop/hbase/fs/TestBlockReorderMultiBlocks.java#L144]
*
[org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner|https://github.com/apache/hbase/blob/master/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java#L154]
> BackupUtils#getWALFilesOlderThan refers to wrong FileSystem
> -----------------------------------------------------------
>
> Key: HBASE-21457
> URL: https://issues.apache.org/jira/browse/HBASE-21457
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Janos Gub
> Assignee: Ted Yu
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: 21457.v1.txt, 21457.v2.txt, 21457.v3.txt, 21457.v3.txt,
> 21457.v4.txt, HBASE-21457.add.patch
>
>
> Janos reported seeing backup test failure when testing a local HDFS for WALs
> while using WASB/ADLS only for store files.
> Janos spotted the code in BackupUtils#getWALFilesOlderThan which uses HBase
> root dir for retrieving WAL files.
> We should use the helper methods from CommonFSUtils.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
