[ https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737437#comment-16737437 ]
Josh Elser commented on HBASE-21456: ------------------------------------ Glanced at the WIP patch briefly: only thing that jumped out at me so far – what if we rename WALFactory to WALProviderFactory. I'm not usually one for renaming quickly, but I think that will make things more semantically correct :) > Make WALFactory only used for creating WALProviders > --------------------------------------------------- > > Key: HBASE-21456 > URL: https://issues.apache.org/jira/browse/HBASE-21456 > Project: HBase > Issue Type: Sub-task > Components: wal > Reporter: Josh Elser > Assignee: Ankit Singhal > Priority: Major > Attachments: HBASE-21456.HBASE-20952.wip.patch > > > As a Factory, WALFactory should only have one job: creating instances of > WALProvider. > However, over the years, it has been a landing place for lots of wal-related > methods (e.g. constructing readers, WALEntryStream, and more). We want all of > this to live in the WALProvider. > We can do this in two steps: have the WALFactory methods invoke the method on > the WALProvider (handled elsewhere), then here we can replace usage of the > WALFactory "wrapper methods" with the WALProvider itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)