[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738512#comment-16738512 ]
Hadoop QA commented on HBASE-21634: ----------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m 9s{color} | {color:green} The patch generated 0 new + 116 unchanged - 9 fixed = 116 total (was 125) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 7s{color} | {color:orange} The patch generated 82 new + 272 unchanged - 6 fixed = 354 total (was 278) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 0s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 38s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21634 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12954338/hbase-21634.master.004.patch | | Optional Tests | dupname asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 179f0d091e29 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 620d70d618 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | rubocop | v0.60.0 | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/15525/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15525/testReport/ | | Max. process+thread count | 2672 (vs. ulimit of 10000) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15525/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -------------------------------------------------------------------------------------- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement > Reporter: Sakthi > Assignee: Sakthi > Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMITĀ areĀ passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNER QUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNER QUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)