[
https://issues.apache.org/jira/browse/HBASE-21693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740953#comment-16740953
]
Andrew Purtell commented on HBASE-21693:
----------------------------------------
The idea behind this change is good and it looks reasonable but the patch needs
more work because it causes existing unit tests to fail. Please set this issue
to 'Patch Available', wait for precommit, check the unit test failures, and
work on it until the latest patch finally passes all unit tests.
I see these failures:
[ERROR] TestRSGroupsAdmin1.testDisabledTableMove:391 » Constraint
org.apache.hadoop.hb...
[ERROR]
org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1.testFailRemoveGroup(org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1)
[ERROR] TestRSGroupsAdmin1.testFailRemoveGroup:241 » Constraint
org.apache.hadoop.hbas...
[ERROR] TestRSGroupsAdmin1.testMultiTableMove:278 » Constraint
org.apache.hadoop.hbase...
[ERROR]
TestRSGroupsAdmin1.testRSGroupListDoesNotContainFailedTableCreation:463 »
Constraint
[ERROR] TestRSGroupsAdmin1.testTableMoveTruncateAndDrop:330 » Constraint
org.apache.ha...
[ERROR] Tests run: 14, Failures: 0, Errors: 5, Skipped: 0
> [rsgroup] Do not attempt to move tables that do not exist
> ---------------------------------------------------------
>
> Key: HBASE-21693
> URL: https://issues.apache.org/jira/browse/HBASE-21693
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
> Reporter: xuqinya
> Assignee: xuqinya
> Priority: Major
> Attachments: HBASE-21693.master.0001.patch
>
>
> In rsgroup, allow to move tables that do not exist. This can cause dirty data.
> {code:java}
> base(main):004:0* move_rsgroup_tables 'rs1',['ttt']
> hbase(main):005:0> get_rsgroup 'rs1'
> GROUP INFORMATION
> Servers:
> 192.168.12.65:16020
> Tables:
> ttt
> {code}
>
> I think it should be like this. As follows:
> {code:java}
> hbase(main):001:0> move_rsgroup_tables 'rs1',['ttt']
> ERROR: org.apache.hadoop.hbase.constraint.ConstraintException: Source group
> is null for table ttt ,table must exist.
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:265)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.moveTables(RSGroupAdminEndpoint.java:174)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:11141)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:675)
> at
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java:52454)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2135)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:107)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:133)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:108)
> at java.lang.Thread.run(Thread.java:745)
> Here is some help for this command:
> Reassign tables from one group to another.
> hbase> move_rsgroup_tables 'dest',['table1','table2']
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
