[
https://issues.apache.org/jira/browse/HBASE-21537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741648#comment-16741648
]
stack commented on HBASE-21537:
-------------------------------
bq. The final goal is to completely remove the getAdmin method from
ClusterConnection, as it exposes the blocking protobuf interface, which will be
a pain when we reimplement sync client based on the async client.
Oh. I see now. Connection#getAdmin returns Admin Interface.
ClusterConnection#getAdmin takes a ServerName and returns the sync impl of pb
Service.
Looking at patch again....
Regards AsyncRegionServerAdmin admin = connection.getRegionServerAdmin(server);
... perhaps s/AsyncRegionServerAdmin/RegionServerAdmin/ and have RSAdmin be
Async only? There'll be the FutureUtils for those who want to do sync? The
Async prefix seems a mouthful.
bq. And no need to change the hbck project, it is hbck1 here, which will be
removed in the future I think.
We might want it in hbck2... but can wait. Or I think the shell does this?
Would have to check.
I'm +1 on commit.
> Rewrite ServerManager.closeRegionSilentlyAndWait to use AsyncClusterConnection
> ------------------------------------------------------------------------------
>
> Key: HBASE-21537
> URL: https://issues.apache.org/jira/browse/HBASE-21537
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Attachments: HBASE-21537-HBASE-21512.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
