[
https://issues.apache.org/jira/browse/HBASE-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228482#comment-13228482
]
stack commented on HBASE-5571:
------------------------------
This patch has much merit. Thanks for digging in on it.
I like how you made a method cancelClosingRegionIfDisabling to hold a bunch of
code that was inside in a catch block.
I see why you want to know if a region is splitting -- it makes it so we can
remove the comments where we speculate a region is splitting -- but I don't
think keeping a list of outstaning regions in HRS the right place for it ... in
particular I don't think we should keep this state in the OnlineRegions
Interface (splitting regions are not online). When we go to split a region, we
put this fact up into zk. Why not check there rather than trying to keep
around a collection of splitting regions?
> Table will be disabling forever
> -------------------------------
>
> Key: HBASE-5571
> URL: https://issues.apache.org/jira/browse/HBASE-5571
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: HBASE-5571.patch
>
>
> If we restart master when it is disabling one table, the table will be
> disabling forever.
> In current logic, Region CLOSE RPC will always returned
> NotServingRegionException because RS has already closed the region before we
> restart master. So table will be disabling forever because the region will in
> RIT all along.
> In another case, when AssignmentManager#rebuildUserRegions(), it will put
> parent regions to AssignmentManager.regions, so we can't close these parent
> regions until it is purged by CatalogJanitor if we execute disabling the
> table.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
