[ 
https://issues.apache.org/jira/browse/HBASE-21733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745689#comment-16745689
 ] 

Sakthi commented on HBASE-21733:
--------------------------------

Left a comment on the rb [~Yi Mei]. :)

> SnapshotQuotaObserverChore should only fetch space quotas
> ---------------------------------------------------------
>
>                 Key: HBASE-21733
>                 URL: https://issues.apache.org/jira/browse/HBASE-21733
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yi Mei
>            Assignee: Yi Mei
>            Priority: Major
>         Attachments: HBASE-21733.master.001.patch
>
>
> In SnapshotQuotaObserverChore.getSnapshotsFromTables method, it fetches space 
> quotas using the following filter:
> {code:java}
> QuotaFilter filter = new QuotaFilter();
> filter.addTypeFilter(QuotaType.SPACE);
> {code}
> but the QuotaType filter hasn't been implemented.
> And if there is throttle quotas in quota table, it will encounter Exception 
> as follows:
> {code:java}
> java.lang.IllegalStateException: Expected only one of namespace and tablename 
> to be null
> at 
> org.apache.hadoop.hbase.quotas.SnapshotQuotaObserverChore.getSnapshotsToComputeSize(SnapshotQuotaObserverChore.java:137)
> at 
> org.apache.hadoop.hbase.quotas.TestSnapshotQuotaObserverChore.testSnapshotsFromNamespaces(TestSnapshotQuotaObserverChore.java:184)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to