[jira] [Comment Edited] (HBASE-18837) HTableMultiplexer behavior during regions split

[kevin su (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747495#comment-16747495
 ] 

kevin su edited comment on HBASE-18837 at 1/20/19 4:57 PM:
-----------------------------------------------------------

{{ScheduledExecutorService executor won't not retry to put, if we don't catch 
the Exception.}}

reference by 
[https://stackoverflow.com/questions/6894595/scheduledexecutorservice-exception-handling]

{{It will stuck by exception.}}

{{Hope this patch help, btw, could i have opportunity to be assigned this 
issue.}}

{{I will try my best to solved it.}}

 
{code:java}
public void run() {
  boolean succ = false;
  try {
    succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut,    
retryCount);
    } catch (Throwable t) {
        LOG.debug("Exception by re-trying the Put");
     } finally {
         FlushWorker.this.getRetryInQueue().decrementAndGet();
         if (!succ) {
           FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
           }
       }
}
{code}
 

 


was (Author: pingsutw):
{{ScheduledExecutorService executor won't not retry to put, if we don't catch 
the Exception.}}

reference by 
[https://stackoverflow.com/questions/6894595/scheduledexecutorservice-exception-handling]

{{It will stuck by exception.}}

{{Hope this patch help, btw, could i have opportunity to be assigned this 
issue.}}

{{I will try my best to solved it.}}

 
{code:java}
public void run() {
boolean succ = false;
try {
succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut, retryCount);
} catch (Throwable t) {
LOG.debug("Exception by re-trying the Put");
} finally {
FlushWorker.this.getRetryInQueue().decrementAndGet();
if (!succ) {
FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
}
}
}
{code}
 

 

> HTableMultiplexer behavior during regions split
> -----------------------------------------------
>
>                 Key: HBASE-18837
>                 URL: https://issues.apache.org/jira/browse/HBASE-18837
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.2
>            Reporter: chausson
>            Priority: Minor
>
> HTableMultiplexer class mentions following in the javadoc : "If any queue is 
> full, the HTableMultiplexer starts to drop the Put requests for that 
> particular queue."
> This could be improved by replacing following code in 
> HTableMultiplexer.resubmitFailedPut() method :
> {code:title=HTableMultiplexer}
> try {
>       succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut, 
> retryCount);
> } finally {
>       FlushWorker.this.getRetryInQueue().decrementAndGet();
>       if (!succ) {
>               FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
>       }
> }
> {code}
> With : 
> {code}
> try {
>       succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut, 
> retryCount);
>       if (!succ) {
>               if (!resubmitFailedPut(ps, oldLoc)) {
>                       
> FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
>               }
>       }
> } finally {
>       FlushWorker.this.getRetryInQueue().decrementAndGet();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)